feat: DH-21100: Allow Formula in rollups #7579
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roupByReaggregateOperator.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ces/aggregate/AggregateColumnSource.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…roupByOperator.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…roupByReaggregateOperator.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cpwright
requested review from
chipkent,
elijahpetty,
jmao-denver,
margaretkennedy and
rcaudy
as code owners
Contributor
lbooker42
reviewed
Jan 22, 2026
| return newOperator; | ||
| } | ||
|
|
||
| GroupByReaggregateOperator ensureGroupByReaggregateOperator(final QueryTable table, |
Contributor
There was a problem hiding this comment.
No Javadoc for this. Not required, but ensureGroupByOperator() above is documented
| @@ -878,8 +1039,9 @@ public void visit(@NotNull final AggSpecFirst first) { | |||
| @Override | |||
| public void visit(@NotNull final AggSpecFormula formula) { | |||
| unsupportedForBlinkTables("Formula"); | |||
| // TODO: re-use shared groupBy operators (https://github.com/deephaven/deephaven-core/issues/6363) | |||
| final GroupByChunkedOperator groupByChunkedOperator = new GroupByChunkedOperator(table, false, null, | |||
| // Note: we do not attempt to reuse the groupBy operator for the deprecated "each" formula, we only reuse | |||
| if (!(source instanceof AggregateColumnSource)) { | ||
| throw new IllegalStateException("Expect to reaggregate AggregateColumnSources for a group operation."); | ||
| } | ||
| @SuppressWarnings("rawtypes") |
Contributor
There was a problem hiding this comment.
This looks odd, used to seeing comment-style inside a code block instead of a decorator. Is this correct usage?
| return newOperator; | ||
| } | ||
|
|
||
| @NonNull |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.